bem / bem-core

BEM Core Library
https://ru.bem.info/technologies/classic/i-bem/
Other
276 stars 95 forks source link

Release 4.0.0 #1310

Closed veged closed 7 years ago

veged commented 8 years ago
narqo commented 8 years ago

Also we need to add some notes about events__observable, as a way to subscribe to bem-events from the outer world (see https://ru.bem.info/forum/1020/#comment-223608883).

tadatuta commented 8 years ago

Add notes about .bem() argument change with examples for complex cases like https://github.com/bem/bem-components/blob/v3/common.blocks/control/control.js#L121

narqo commented 8 years ago

Don't forget to add changes from #1376 to the migration guide.

tadatuta commented 8 years ago

Add note about getDefaultParams -> _getDefaultParams to https://github.com/bem/bem-core/blob/v4/MIGRATION.ru.md#Имена-protected-методов-начинаются-с-_

tadatuta commented 8 years ago

There are two methods getName and getEntityName returning the same result (https://github.com/bem/bem-core/blob/v4/common.blocks/i-bem/i-bem.vanilla.js#L485-L499). Which to use and why?

narqo commented 8 years ago

getEntityName returns full BEM entity name, e.g. button or Input__clear in case of elem instance. getName returns self name of the entity: button and clear for the same examples as above.

The former is primary used to build proper CSS class and to distinguish block instance from the elem.

tadatuta commented 8 years ago

@narqo take a look at the link I provided, the methods are implemented absolutely the same way (return this._name;).

narqo commented 8 years ago

Yes, but getEntityName() is overridden in Elem class. Check L541.

tadatuta commented 8 years ago

Update migration guide about _elems() method (remove it from https://github.com/bem/bem-core/blob/v4/MIGRATION.ru.md#Имена-protected-методов-начинаются-с-_) and describe difference about this.elem() VS this.elems().domElem now.

aristov commented 8 years ago

This works in older versions:

Suggest.declMod({ modName : 'has-dataprovider' });

but doesn't work in v4. Works only with asteriks:

Suggest.declMod({ modName : 'has-dataprovider', modVal : '*' });
dfilatov commented 8 years ago

@aristov see #1374

tadatuta commented 8 years ago

Looks like https://github.com/bem/bem-core/issues/1310#issuecomment-227145103 was missed.