search

bem / bem-history

BEM wrap for History API
https://bem.info/libs/bem-history/
Other
22 stars 20 forks source link

Corrected uri parser regular expression #42

Closed GreLI closed 8 years ago

GreLI commented 8 years ago

URI parsing regular expression incorrectly parses uris like http://example.com/?text=@fake.com as http://fake.com. It seems due to outdated regular expression, so I've updated it from jsUri referenced inside the code. Comparing to the original I removed isColonUri group, since it isn't used here.

P.S. Tests are failing for me in the main branch as well.

tadatuta commented 8 years ago

actually tests passed

GreLI commented 8 years ago

Good news! Updated the PR to meet comments.

tadatuta commented 8 years ago

@GreLI Thank you!