bem / bem-react

A set of tools for developing user interfaces using the BEM methodology in React
http://bem.github.io/bem-react
Other
439 stars 64 forks source link

feat: Upgrade to react@18 #622

Closed Coudnet closed 1 year ago

maxim-kolesnikov commented 2 years ago

@yarastqt so, can we publish it? πŸ™

maxim-kolesnikov commented 2 years ago

@Coudnet

Hi, I'm having some trouble installing "devDependencies" from the root of the project, can you tell me your environment versions, I'd like to test your solution locally.

(base) ➜  bem-react git:(issue-621) node -v
v18.12.1
(base) ➜  bem-react git:(issue-621) lerna -v 
5.6.2
(base) ➜  bem-react git:(issue-621) npm run bootstrap

> bootstrap
> lerna bootstrap --no-ci

lerna notice cli v5.6.2
lerna info versioning independent
lerna info Bootstrapping 7 packages
lerna info Installing external dependencies
lerna info Symlinking packages and binaries
lerna info lifecycle @bem-react/pack@1.6.0~prepare: @bem-react/pack@1.6.0

> @bem-react/pack@1.6.0 prepare /Users/user/Desktop/bem-react/packages/pack
> npm run build:manifest

(##################) β ‡ prepare: sill lifecycle No script for "prepare" in "@bem-react/core", continuing
> @bem-react/pack@1.6.0 build:manifest
> oclif-dev manifest

wrote manifest to /Users/user/Desktop/bem-react/packages/pack/oclif.manifest.json
lerna success Bootstrapped 7 packages
(base) ➜  bem-react git:(issue-621) cd node_modules 
(base) ➜  node_modules git:(issue-621) ls -la
total 0
drwxr-xr-x   3 user  staff   96 22 ноя 12:53 .
drwxr-xr-x  25 user  staff  800 23 ноя 13:48 ..
drwxr-xr-x   3 user  staff   96 22 ноя 12:53 .cache
(base) ➜  node_modules git:(issue-621) 
veged commented 2 years ago

@yarastqt so, can we publish it? πŸ™

I'll review and publish it (just need few more days).

Coudnet commented 2 years ago

@Coudnet

Hi, I'm having some trouble installing "devDependencies" from the root of the project, can you tell me your environment versions, I'd like to test your solution locally.

@maxim-kolesnikov

Hi! My environment versions:

> bem-react % node -v
v18.12.1
> bem-react % npm -v
6.14.17
> bem-react % ./node_modules/.bin/lerna -v
3.5.1

I don't have global lerna, so my version is from package.json

Coudnet commented 2 years ago

@veged Hi! Can you take a review, please?

maxim-kolesnikov commented 2 years ago

Maybe we can publish in npm from this thread with the alpha tag? πŸ₯²

veged commented 2 years ago

Maybe we can publish in npm from this thread with the alpha tag? πŸ₯²

isn't it the same as just using from git URL? ;-)

I'll try to do this by the end of the week 🀞🏻

maxim-kolesnikov commented 2 years ago

isn't it the same as just using from git URL? ;-)

I thought so too, but lerna does not install dependencies from your root of project, only if I call yarn / npm run in u project.

maxim-kolesnikov commented 1 year ago
πŸ€·πŸ»β€β™‚οΈ image
veged commented 1 year ago

sorry, guys, it might take more time because with React 18 we need to rewrite a lot of things (i.e. tests from Enzyme)... I'm in progress...

maxim-kolesnikov commented 1 year ago

πŸ”₯

veged commented 1 year ago

@maxim-kolesnikov @Coudnet new versions published to NPM

maxim-kolesnikov commented 1 year ago
image