search

bem / bem-sdk

BEM SDK packages
https://en.bem.info/toolbox/sdk/
86 stars 24 forks source link

entity-name: type of modifier value #310

Open yarastqt opened 6 years ago

yarastqt commented 6 years ago

ModifierValue must be string or boolean

Yeti-or commented 6 years ago

right now modifier could be a string or true let's make it string or boolean https://github.com/bem/bem-sdk/blob/master/packages/entity-name/types/globals.d.ts#L10

qfox commented 6 years ago

Let's don't because it's entity-name and can't contain false val for modifier because of that. What you talking about is value of modifier inside bemjson-node.mods container. Bet we need BemjsonNodeMods interface.

qfox commented 6 years ago

As a quick hack you can pull request a patch with interface declaration based on current type. Feel free to implement it!