bem / bem-xjst

bem-xjst (eXtensible JavaScript Templates): declarative template engine for the browser and server
https://bem.github.io/bem-xjst
Other
116 stars 48 forks source link

attrEscape should escape accent grave (`) #357

Closed miripiruni closed 7 years ago

miripiruni commented 8 years ago

https://html5sec.org/#59

miripiruni commented 8 years ago

Perf test result:

Test started…
{ 
  rev1: '47007e77cca6a7c20a0f21e21654d274ca238132',
  rev2: '5ab2e2fc3d13ef95ae6c1fdd34f3cfe9f25580db',
  bemjson: 10000,
  dataPath: '/Users/miripiruni/bemjson',
  templatePath: './node_modules/web-data/templates.js',
}

Wed Sep 28 2016 17:06:48 GMT+0300 (MSK)
Total test time:  241885.128583
./lib/compare.py ./dat-47007-5ab2e ./dat-47007-5ab2e/47007e77cca6a7c20a0f21e21654d274ca238132-10000-1475071730618.dat ./dat-47007-5ab2e/5ab2e2fc3d13ef95ae6c1fdd34f3cfe9f25580db-10000-1475071850113.dat

Percentile:  0.5
{ rev1: 8.010404,
  rev2: 7.794366,
  'diff abs': 0.2160379999999993,
  'diff percent': 2.6969675936444615 }

Percentile:  0.9
{ rev1: 11.375389,
  rev2: 11.114701,
  'diff abs': 0.26068800000000003,
  'diff percent': 2.291684266797378 }

Percentile:  0.95
{ rev1: 13.415111,
  rev2: 13.260861,
  'diff abs': 0.15424999999999933,
  'diff percent': 1.1498227633002789 }
miripiruni commented 7 years ago

Won’t fix, see https://github.com/bem/bem-xjst/pull/358#issuecomment-259410469