search

bem / webpack-bem-loader

Webpack BEM loader
Other
25 stars 14 forks source link

add sets support #49

Closed Lakate closed 6 years ago

Lakate commented 6 years ago

i'l fix after merge https://github.com/bem/bem-sdk/pull/213

Yeti-or commented 6 years ago

@Lakate @bem/sdk.config@0.0.4 is out

Lakate commented 6 years ago

@Yeti-or merge? roll out a new version ?

awinogradov commented 6 years ago

It's not needed here. It's supported in https://github.com/bem/create-bem-react-app/pull/31 and https://github.com/bem/create-bem-react-app/pull/32.

Yeti-or commented 6 years ago

@awinogradov Why it's not needed here??

awinogradov commented 6 years ago

Because it's loader. Loader works with targets from webpack-config. Also, we don't need sets infromation in the loader, because of no reasons. Also, we have instruments to do this support early and parallel. Look at the comment above. Also, supporting sets here can't help to do anything.

awinogradov commented 6 years ago

@Lakate @Vittly is it actual PR or you will support this in https://github.com/bem/webpack-bem-plugin?

Vittly commented 6 years ago

It is already supported in plugin. Can be closed