Do not throw on Webpack v4

bem / webpack-bem-loader

Webpack BEM loader

Other

25 stars 14 forks source link

Do not throw on Webpack v4 #81

Closed amje closed 6 years ago

amje commented 6 years ago

Property this.options has been deprecated since webpack 3. In webpack 4 it's removed completely. To support both the new version and the old ones simple check added.

coveralls commented 6 years ago

Coverage increased (+0.1%) to 93.038% when pulling 1805e1e5485b37bfaa6e9e6610dfc1c020796bd7 on amje:webpack4 into d509488d5397d53286dbec68a17f052e28e618b1 on bem:master.

keann commented 6 years ago

Actually, it wasn't, just moved to this._compiler.options. Also on the way to close #63 you anyway should update dev dependencies to webpack v4 and try to run tests )

amje commented 6 years ago

Yeah... I think I should rename this PR to "Do not throw on webpack v4" ) To support webpack v4 we have to do way more work in tests: CommonsChunkPlugin -> SplitChunksPlugin, ExtractTextWebpackPlugin -> MiniCssExtractPlugin and maybe something else.

Yeti-or commented 6 years ago

@amje sorry for such long delay I'll add full support in separate pr