search

bemailr / wp-requirements

Check server and site conditions before activating your WordPress plugin or theme
http://bemailr.github.io/wp-requirements/
GNU General Public License v3.0
7 stars 1 forks source link

Default action: nothing? Or notice. #21

Closed tivnet closed 8 years ago

tivnet commented 8 years ago

https://github.com/slaFFik/wp-requirements/blob/f89eaa9416040d7e89163eef568e82f4f7d86205/wp-requirements.php#L73

I believe, deactivating by default is wrong. Should be no action or maybe only the notice.

slaFFik commented 8 years ago

Plugin can cause damage to the site if it is not deactivated when not meeting requirements. White screen of death etc. I believe, deactivation be default is ok, and plugin developer when creating his wp-requirements.json file, can change the default behaviour. So I'm ok with leaving this as is.

tivnet commented 8 years ago

I am thinking about temporary deactivation of the main plugin (say WooCommerce) causing a cascade of deactivations of all dependants.