search

bemailr / wp-requirements

Check server and site conditions before activating your WordPress plugin or theme
http://bemailr.github.io/wp-requirements/
GNU General Public License v3.0
7 stars 1 forks source link

Loading the latest version only? #24

Closed tivnet closed 8 years ago

tivnet commented 8 years ago

Two options:

  1. Give a new class name to each new major release. For instance, rename the class to WP_Requirements_2 now. This means that any additional functionality will bump the major release. Not practical, probably.
  2. Use a hook loading of the class (similar to CMB2).
tivnet commented 8 years ago

In the hook loading, still need to worry about the major version changes.

So, probably, we need both: class name matching the major release # and the hook loading.

@slaFFik If you confirm the WP_Requirements_2 change, we should do it now before the develop is merged with master.

tivnet commented 8 years ago

How about keeping both the old wp-requirements.php and the new wp-requirements-2.php in the repository? Those who need and want to upgrade will modify their code. This should solve the backward incompatibility problems, because, with each major release, we'll make a new file and new class name.

► Still need the hook loading to get the latest minor release.

slaFFik commented 8 years ago

I agree with the arguments and a proposed solution here :)

tivnet commented 8 years ago

@slaFFik Please check the implementation and if OK, let's make it 2.0.0

Note that the old class is kept as-is.