P3168R1: use a non-pointer iterator type

[neatudarius]

P3168R1: use a non-pointer iterator type . Follow-up PR after #9 for suggestion made by @brevzin (issue #14) .

Updates:

• include/Beman/Optional26/detail/iterator.hpp: Adopt normal_iterator implementation from GCC and create a simplified version into beman::optional::detail:normal_iterator.
• include/Beman/Optional26/optional.hpp: Replace implementation for optional<T/T&>::iterator/const_iterator: T*/const* -> detail::normal_iterator<T/const T*, optional> .
• Add more tests related to iterators.

Notes:

• This should be a very small PR (interesting diff in optional.hpp, also possible in iterator.hpp).
• A long-term implementation for the iterator type will be done in #17. Now we just want something good enough to be able to make experiments for LWG@Saint Louis. L.E. As discussed in this thread, I copied the stl_interfaces Boost implementation into our tree (#17).

[steve-downey]

I had a little time this weekend: https://github.com/steve-downey/iterator-interface It's an implementation from the wording and exposition from P2727R4 - Only "creative" bit was writing the iterator tag calculation.

Did turn up some wording nits, so not totally useless.

On Mon, Jun 24, 2024 at 10:24 AM David Sankel @.***> wrote:

@.**** commented on this pull request.

In include/Beman/Optional26/detail/stl_interfaces/iterator_interface.hpp https://github.com/beman-project/Optional26/pull/18#discussion_r1651131899 :

@@ -0,0 +1,986 @@ +// include/Beman/Optional26/detail/stl_interfaces/iterator_interface.hpp --C++-- +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

Well, unless you could get @tzlaine https://github.com/tzlaine to give you an "Apache-2.0 WITH LLVM-exception" license to his code. That would make it simpler.

— Reply to this email directly, view it on GitHub https://github.com/beman-project/Optional26/pull/18#discussion_r1651131899, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVNZ5ULSRO7WEH5B5X6IMTZJATZPAVCNFSM6AAAAABJSJ3H3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZVHE3TCMBYGQ . You are receiving this because your review was requested.Message ID: @.***>

[neatudarius]

I had a little time this weekend: https://github.com/steve-downey/iterator-interface It's an implementation from the wording and exposition from P2727R4 - Only "creative" bit was writing the iterator tag calculation. Did turn up some wording nits, so not totally useless.

Nice! Thanks Steve! I think we can start a chat with @tzlaine and see that's the plan for stl_interfaces inside Beman.

Note: We'll continue using sources from boost/stl_interfaces in this PR.

[neatudarius]

Merged the PR to be able to deploy into Compiler Explorer (#21 ).

Follow-up tweaks will be done in other PRs.