search

beman-project / Optional26

Beman.Optional26: `std::optional` extensions targeting C++26
Apache License 2.0
4 stars 4 forks source link

update LWG status and add a godbolt link to docs #24

Closed JeffGarland closed 5 days ago

JeffGarland commented 5 days ago

Updates before the presentation tonight

JeffGarland commented 5 days ago

LGTM 👍 , but I propose to move this diff in my PR (#23) or to update the included link in this PR:

* your link https://godbolt.org/z/b5ThEqqhf

* my links have a specific format (license, multiple compilers/C++ standards): https://godbolt.org/z/f8dWaxsGo (btw, this link is already included for the same example in `examples/README.md` in my branch, not it's also pushed into the root README)

I'm aware of the link you put in the other PR -- it's just a little overwhelming to see all the sub-windows popping up. This was more curated for a presentation audience to 'see a small code snippet' and discuss things like the include path and namespaces.

How about I merge and you can sort out the final set of links in yours?

neatudarius commented 5 days ago

LGTM 👍 , but I propose to move this diff in my PR (#23) or to update the included link in this PR:

* your link https://godbolt.org/z/b5ThEqqhf

* my links have a specific format (license, multiple compilers/C++ standards): https://godbolt.org/z/f8dWaxsGo (btw, this link is already included for the same example in `examples/README.md` in my branch, not it's also pushed into the root README)

I'm aware of the link you put in the other PR -- it's just a little overwhelming to see all the sub-windows popping up. This was more curated for a presentation audience to 'see a small code snippet' and discuss things like the include path and namespaces.

How about I merge and you can sort out the final set of links in yours?

Sure. Ship it!