beman-project / optional26

Beman.Optional26: `std::optional` extensions targeting C++26
Apache License 2.0
13 stars 8 forks source link

Improve local and CI flows #26

Closed neatudarius closed 1 day ago

neatudarius commented 3 months ago

TLDR: scripts for local and CI flows. #1 #2 #11 #16 The codebase (e.g. C++ files) are not updated in this PR. I will make a new PR an update main and rebase this branch until this PR becomes green!

===========================================================================

Updates already applied:

image image

===========================================================================

Next steps:

steve-downey commented 3 months ago

I'll take a look at what the lint fixes would do before approving this, but I'm in principle in favor of all it.

I have no strong feelings about markdown, shell, yaml, and json formatting -- all of them are terrible and I don't particularly care.

Slight preferences about C++ formatting, although as long as clang-format can put things back in canonical form it's only a slight preference. And with Lint Cpp currently green, it looks like I'm OK.

neatudarius commented 1 month ago

Related PR - #52 . Will discuss with @steve-downey the approach.

neatudarius commented 6 days ago

Put this PR on hold until we solve similar issue/discussion for beman.exampler.

camio commented 5 days ago

Put this PR on hold until we solve similar issue/discussion for beman.exampler.

I think a good way to do that would be to mark it as a draft PR.

neatudarius commented 5 days ago

Put this PR on hold until we solve similar issue/discussion for beman.exampler.

I think a good way to do that would be to mark it as a draft PR.

It seems it cannot be put back to draft. I will temporary close it.