search

beman-project / optional26

Beman.Optional26: `std::optional` extensions targeting C++26
Apache License 2.0
13 stars 8 forks source link

Make Optional26 Packageable #28

Open bretbrownjr opened 3 months ago

bretbrownjr commented 3 months ago

I attempted to add Optional26 to the Conan local recipe index I am finishing up in https://github.com/beman-project/beman/pull/21.

Two problems (so far):

The first issue can be fairly trivially resolved by clicking using the release feature in the github.com web UI and cutting a release. Of course, an established process and even CI for this task would be great, including developing patterns and CI scripts that other beman projects could benefit from.

The second issue could be a matter of making the relevant add_subdirectory conditional somehow, using find_package workflows instead and adding googletest as a package dependency in Conan to ensure it's available to build against. It's also possible that using FetchContent instead of git-submodules would make the packaging "work", but Conan is designed such that it does source code indexing and fetching, so I would prefer to adhere to that design when using Conan.

neatudarius commented 3 months ago

Hello @bretbrownjr !

The first issue can be fairly trivially resolved by clicking using the release feature in the github.com web UI and cutting a release. Of course, an established process and even CI for this task would be great, including developing patterns and CI scripts that other beman projects could benefit from.

I propose to discuss on Monday in the Beman sync. I think we should have an unified approach (including scripts, CI jobs) for releases in Beman Project. Do we have a script or a CI job for Beman.Example?

The second issue could be a matter of making the relevant add_subdirectory conditional somehow, using find_package workflows instead and adding googletest as a package dependency in Conan to ensure it's available to build against. It's also possible that using FetchContent instead of git-submodules would make the packaging "work", but Conan is designed such that it does source code indexing and fetching, so I would prefer to adhere to that design when using Conan.

I created #29 29. Does this help as an intial step?

neatudarius commented 2 months ago

@bretbrownjr , #29 was merged. I think we need to update the issue description.