Improve ci - Githubissues

beman-project / exemplar

Example Beman project

Other

10 stars 16 forks source link

Improve ci #6

Closed mguid65 closed 1 month ago

mguid65 commented 6 months ago

Modify CI to use default images from github
- Add windows, linux, and macos
- Note:
  - For Ninja, we have to fetch it from an external source
  - For Windows, we have to do some work to setup the msvc dev environment
  - For both of the above, these are accomplished by using public actions from the marketplace
    - This may not be appropriate and so we may have to do something different

wusatosi commented 1 month ago

Is there any update to this pr? I wish to propose similar changes like this, is there a specific reason there's no update here?

@neatudarius @camio @bbrown105

mguid65 commented 1 month ago

I apologize, the reason for the lack of updates is that I forgot I made this PR.

We can either continue with proposed changes to this or we can discard it.

wusatosi commented 1 month ago

@mguid65 , would you like to update your branch with latest main before continue with this review? Some changes are not applicable anymore.

e.g. Due to one usage examples, now the project requires C++20 or later.

Would you like to try to re-enable this example on your updated branch https://github.com/beman-project/exemplar/blob/main/examples/CMakeLists.txt#L4?

I think this PR is abandoned, see: https://github.com/beman-project/exemplar/issues/27#issuecomment-2371527251, and the comment above.

I can fork this PR and pick this up.

neatudarius commented 1 month ago

As per previous reply, I closed this PR to avoid more confusion, we can fork it later.