Closed neatudarius closed 1 week ago
Note the CI build failures.
Note the CI build failures.
I can give some insight into the CI failure here. The failed CI ("defaults") are those that doesn't have a C++ version defined.
This came up to me during refactoring as it's a weird setup, without setting C++ version CMake fallbacks into a platform defined (old) C++ version. I forgot to bring these up.
Basically they fall back to a version < 17 and failed to compile, thus the broken checks.
I don't know why it's broken now instead of earlier.
Given the cmake C++ standard conflict @camio mentioned before, we are prob not putting required minimum version in CMake scripts. Thus we should supply the C++ version for all command line invocation of CMake.
Those tests are in some sense erroneous.
Edit: or maybe the version detection code is erroneous?
Given we will start to conditionally run tests and examples based on C++ versions, we prob want to extend sanitizer-enabled CI tests to all versions as well. I can file this as a separate PR.
See: #57
Any interest in progressing this? I can come update it. @neatudarius
Any interest in progressing this? I can come update it. @neatudarius
You can take over. I'm busy with iterator_interface this week.
Should be working now, see: Unit: gcc 17 Default, that reports identity_as_default_projection
is not being build. while Unit: gcc 20 Default no longer report this.
Updated default C++ version in preset to C++ 20 (previously C++17) so that all examples are built by default.
Should be ready! requesting review from original PR author @neatudarius
Closes #41 - re-enable example with ranges support. It is skipped on compilers with no ranges support or when using C++17 or older.
Log sample: