search

bemanproject / exemplar

Example Beman project
Other
11 stars 16 forks source link

[DO NOT MERGE] Test reviewdog 2 #58

Closed wusatosi closed 1 month ago

wusatosi commented 1 month ago

Sorry again for spamming the notification.

Similar to #53 , trying to debug the permission issue of review dog.

Different to #53, this pr opens a pr from within the project instead of a fork. I suspect the permission issue may be because it's a pr from a fork.

Expected:

  1. pre-commit flags the clang-format and white space linting issue and generates fixes
  2. Review dog suggests fixes via Pull Request reviews.
wusatosi commented 1 month ago

Weird, this shouldn't pass at all...

https://github.com/beman-project/exemplar/actions/runs/11469332766/job/31916366106?pr=58

wusatosi commented 1 month ago

why is the pull request event not triggering?????

wusatosi commented 1 month ago

Close the pr as its not helping at all.. Notes the push event is passing which it shouldn't