Closed dtinth closed 6 years ago
Merging #492 into master will increase coverage by
0.01%
. The diff coverage is91.66%
.
@@ Coverage Diff @@
## master #492 +/- ##
=========================================
+ Coverage 84.09% 84.1% +0.01%
=========================================
Files 170 171 +1
Lines 5370 5387 +17
Branches 1 1
=========================================
+ Hits 4516 4531 +15
- Misses 854 856 +2
Impacted Files | Coverage Δ | |
---|---|---|
packages/bms/spec/reader_spec.js | 100% <100%> (ø) |
:arrow_up: |
packages/bemuse-notechart/src/loader/index.js | 100% <100%> (ø) |
:arrow_up: |
packages/bemuse-indexer/src/index.js | 93.8% <100%> (+0.05%) |
:arrow_up: |
packages/bms/src/reader/index.js | 85% <100%> (+3.75%) |
:arrow_up: |
...ges/bms/src/reader/getReaderOptionsFromFilename.js | 75% <75%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 634597a...c1d8d3a. Read the comment docs.
Rationale:
Character set detection is sometimes inaccurate. To allow overriding the encoding without changing content, creators can specify the encoding of the file through file naming.
.utf8.bms
— Always read as UTF-8.sjis.bms
— Always read as Shift-JIS.euc_kr.bms
— Always read as EUC-KRTasks: