bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 147 forks source link

Make bms and bmson package TypeScripted #520

Closed dtinth closed 5 years ago

dtinth commented 5 years ago

This PR:

codecov-io commented 5 years ago

Codecov Report

Merging #520 into master will decrease coverage by 1.21%. The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   83.25%   82.04%   -1.22%     
==========================================
  Files         172      167       -5     
  Lines        5423     5129     -294     
  Branches        1       68      +67     
==========================================
- Hits         4515     4208     -307     
+ Misses        908      903       -5     
- Partials        0       18      +18
Impacted Files Coverage Δ
packages/bms/src/notes/channels.ts 100% <ø> (ø)
packages/bms/src/util/lodash.ts 100% <ø> (ø)
packages/bms/src/bms/chart.ts 100% <100%> (ø)
packages/bms/src/notes/note.ts 100% <100%> (ø)
packages/bms/src/util/match.ts 100% <100%> (ø)
packages/bms/src/bms/objects.ts 84.21% <100%> (ø)
...ges/bms/src/reader/getReaderOptionsFromFilename.ts 37.5% <100%> (ø)
packages/bms/src/bms/headers.ts 80% <100%> (ø)
packages/bms/src/time-signatures/index.ts 92.3% <100%> (ø)
packages/bms/src/notes/index.ts 94.11% <100%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2dad7f6...7dfde80. Read the comment docs.