Closed dtinth closed 5 years ago
Fails | |
---|---|
:no_entry_sign: | src/sampling-master/vendor/stbvorbis/stbvorbis-e6da5fe.js is not formatted using Prettier. |
Messages | |
---|---|
:book: | You can run `yarn style:fix` to automatically format all files using Prettier. |
Generated by :no_entry_sign: dangerJS
Merging #534 into master will decrease coverage by
0.72%
. The diff coverage is14.89%
.
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 81.38% 80.65% -0.73%
==========================================
Files 153 154 +1
Lines 4619 4667 +48
Branches 68 68
==========================================
+ Hits 3759 3764 +5
- Misses 842 885 +43
Partials 18 18
Impacted Files | Coverage Δ | |
---|---|---|
src/sampling-master/ogg.js | 4.87% <4.87%> (ø) |
|
src/sampling-master/index.js | 95.72% <83.33%> (-3.37%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cb891f5...138f0d7. Read the comment docs.
Closes #509
Thanks to @hajimehoshi’s stbvorbis.js, it works pretty well and now allows Bemuse to support OGG/Vorbis in iOS and Safari!
Changelog
OGG support is added to iOS and Safari, using [@hajimehoshi]’s stbvorbis.js library to decode OGG files in-browser. This means that Bemuse no longer relies on proprietary audio file format (m4a) to function in Safari and iOS, and thus:
Generating a Bemuse package is faster because m4a files no longer to be generated.
Less disk space requirement as only ogg files are needed.
A Bemuse package can now be generated on Linux, due to proprietary tools to use Apple’s m4a encoder is no longer needed.
With this change, creating content for Bemuse will become easier and more accessible!