search

bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 147 forks source link

Use NDEBUG version of stbvorbis.js #553

Closed dtinth closed 5 years ago

dtinth commented 5 years ago

On iOS, when decoding OGG using stbvorbis.js, an assertion error occurred. It’s very strange that it doesn’t happen on Safari for Mac. As a “hacky” fix, I disabled assertions and recompiled the library using -DNDEBUG flag. It is not elegant… but it works. :joy:

Changelog

Fixed an issue where the OGG sound decoder crashes when decoding some OGG files in iOS.

codecov-io commented 5 years ago

Codecov Report

Merging #553 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files         156      156           
  Lines        4760     4760           
  Branches      184      184           
=======================================
  Hits         3849     3849           
  Misses        862      862           
  Partials       49       49
Impacted Files Coverage Δ
...aster/vendor/stbvorbis/stbvorbis-e6da5fe-NDEBUG.js 100% <ø> (ø)
src/sampling-master/ogg.ts 79.16% <ø> (ø) :arrow_up:
...pling-master/vendor/stbvorbis/stbvorbis-e6da5fe.js

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 110b875...e765edb. Read the comment docs.