bemusic / bemuse

β¬€β–—β–šβ–šβ–š Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 147 forks source link

πŸ™ Migrate part of the code from `co` to `async function`s #655

Closed dtinth closed 4 years ago

dtinth commented 5 years ago

Changelog

Migrate part of the code from co to async functions. (#639, by [@TayHobbs]; #641, #642, #643, #645, #649, by [@mslourens]; #646, by [@setheal]; #652, by [@511V41]; #656, by [@aboudicheng]; #657, by [@pnkapadia64]).

codecov-io commented 4 years ago

Codecov Report

Merging #655 into master will increase coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   80.91%   81.07%   +0.15%     
==========================================
  Files         156      156              
  Lines        4757     4776      +19     
  Branches      184      184              
==========================================
+ Hits         3849     3872      +23     
+ Misses        859      855       -4     
  Partials       49       49              
Impacted Files Coverage Ξ”
src/game/display/player-display.js 77.06% <100.00%> (+1.23%) :arrow_up:
src/scintillator/index.spec.js 99.60% <100.00%> (-0.40%) :arrow_down:
src/scintillator/loader.js 85.36% <100.00%> (-0.35%) :arrow_down:
src/scintillator/nodes/if.js 94.73% <0.00%> (+10.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 3e167fb...5f5707f. Read the comment docs.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication