bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 147 forks source link

Converting usage of co to async functions src/coming-soon/demo/index #657

Closed pnkapadia64 closed 4 years ago

pnkapadia64 commented 5 years ago

Fixes #627

codecov-io commented 5 years ago

Codecov Report

Merging #657 into master will decrease coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   81.07%   80.91%   -0.16%     
==========================================
  Files         156      156              
  Lines        4776     4757      -19     
  Branches      184      184              
==========================================
- Hits         3872     3849      -23     
- Misses        855      859       +4     
  Partials       49       49              
Impacted Files Coverage Δ
src/scintillator/nodes/if.js 84.21% <0.00%> (-10.53%) :arrow_down:
src/game/display/player-display.js 75.83% <0.00%> (-1.24%) :arrow_down:
src/scintillator/loader.js 85.71% <0.00%> (+0.34%) :arrow_up:
src/scintillator/index.spec.js 100.00% <0.00%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4003756...6cfd053. Read the comment docs.

pnkapadia64 commented 5 years ago

Hey @dtinth, can you take a look at this and merge it if it looks alright?

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication