bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 149 forks source link

Replaced `updeep` with `immer` #709

Closed aadityasinha-dotcom closed 3 years ago

aadityasinha-dotcom commented 3 years ago

Issue Id you have worked upon -

704

CHANGES MADE -

Added the latest version of immer in the bemuse/package.json and removed the updeep from the dependencies.

Made changes to -

https://github.com/bemusic/bemuse/blob/master/.vscode/settings.json https://github.com/bemusic/bemuse/blob/master/bemuse/package.json

NOTE -

Please consider this PR as a submission towards Hacktoberfest 2021 and add the hacktoberfest-accepted label to it.

dtinth commented 3 years ago

@aadityasinha-dotcom Thank you for the contribution… however it does not satisfy the criteria outlined in #704 yet. I think you will also have to update the code that uses the updeep package to use immer. If it is done correctly, then these automated checks should pass.

image

aadityasinha-dotcom commented 3 years ago

@aadityasinha-dotcom Thank you for the contribution… however it does not satisfy the criteria outlined in #704 yet. I think you will also have to update the code that uses the updeep package to use immer. If it is done correctly, then these automated checks should pass.

image

OK

sonarcloud[bot] commented 3 years ago

Please retry analysis of this Pull-Request directly on SonarCloud.