Closed aadityasinha-dotcom closed 3 years ago
@aadityasinha-dotcom Thank you for the contribution… however it does not satisfy the criteria outlined in #704 yet. I think you will also have to update the code that uses the updeep
package to use immer
. If it is done correctly, then these automated checks should pass.
@aadityasinha-dotcom Thank you for the contribution… however it does not satisfy the criteria outlined in #704 yet. I think you will also have to update the code that uses the
updeep
package to useimmer
. If it is done correctly, then these automated checks should pass.
OK
Please retry analysis of this Pull-Request directly on SonarCloud.
Issue Id you have worked upon -
704
CHANGES MADE -
Added the latest version of
immer
in thebemuse/package.json
and removed theupdeep
from the dependencies.Made changes to -
https://github.com/bemusic/bemuse/blob/master/.vscode/settings.json https://github.com/bemusic/bemuse/blob/master/bemuse/package.json
NOTE -
Please consider this PR as a submission towards Hacktoberfest 2021 and add the hacktoberfest-accepted label to it.