bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Convert updeep to immer (fixes #704) #755

Closed cxong closed 1 year ago

cxong commented 1 year ago

Changelog

Migrated the data update library from updeep to immer.

cxong commented 1 year ago
Screen Shot 2022-10-15 at 4 50 58 pm

I'm unable to test further due to 403 errors

dtinth commented 1 year ago

@cxong Hi! Many thanks for contributing.

The 403 error comes from loading a background image and should not affect the game.

To verify that the game works, please run the end-to-end tests, found in the e2e folder.

cxong commented 1 year ago

I am getting

Step 1. Open browser NG 3s
        Error: net::ERR_CONNECTION_REFUSED at http://localhost:8080/?server=https://raw.githubusercontent.com/bemusic/bemuse-test-server/master

after running

npx prescript tests/Gameplay-test.js

in e2e

dtinth commented 1 year ago

@cxong Hi! Please have the development server running while running the E2E tests.

cxong commented 1 year ago
Deferred Step 2. Close browser OK 85ms
すばらしい! 32s
dtinth commented 1 year ago

@cxong Great, seems to be working! Almost there — please check the CI status.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication