bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 149 forks source link

Remove `co` dependency #772

Closed MikuroXina closed 2 years ago

MikuroXina commented 2 years ago

Resolves #575, #632, #633. The work of removal should be finished up by this change.

Changelog

Removed dependency on the co library.

dtinth commented 2 years ago

Thanks a lot for the contribution!

p.s. feel free to ignore CircleCI for now, it regularly OOM-kills the build process 😞

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.1% 0.1% Duplication

codecov-commenter commented 2 years ago

Codecov Report

Base: 81.05% // Head: 81.05% // No change to project coverage :thumbsup:

Coverage data is based on head (479d83b) compared to base (34eba96). Patch coverage: 87.91% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #772 +/- ## ======================================= Coverage 81.05% 81.05% ======================================= Files 178 178 Lines 5290 5290 Branches 242 242 ======================================= Hits 4288 4288 Misses 931 931 Partials 71 71 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/app/options.js](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvb3B0aW9ucy5qcw==) | `27.77% <ø> (ø)` | | | [bemuse/src/custom-folder/index.spec.ts](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9jdXN0b20tZm9sZGVyL2luZGV4LnNwZWMudHM=) | `93.54% <ø> (ø)` | | | [bemuse/src/custom-folder/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9jdXN0b20tZm9sZGVyL2luZGV4LnRz) | `62.43% <ø> (ø)` | | | [...emuse/src/custom-song-loader/song-loader.worker.js](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9jdXN0b20tc29uZy1sb2FkZXIvc29uZy1sb2FkZXIud29ya2VyLmpz) | `100.00% <ø> (ø)` | | | [bemuse/src/devtools/benchmark.js](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9kZXZ0b29scy9iZW5jaG1hcmsuanM=) | `5.12% <0.00%> (ø)` | | | [bemuse/src/devtools/ui/BenchmarkPanel.jsx](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9kZXZ0b29scy91aS9CZW5jaG1hcmtQYW5lbC5qc3g=) | `7.14% <ø> (ø)` | | | [bemuse/src/game/audio/player-audio.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2F1ZGlvL3BsYXllci1hdWRpby5zcGVjLmpz) | `100.00% <ø> (ø)` | | | [bemuse/src/game/display/touch3d.js](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2Rpc3BsYXkvdG91Y2gzZC5qcw==) | `6.06% <0.00%> (ø)` | | | [bemuse/src/game/test-helpers/index.js](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL3Rlc3QtaGVscGVycy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | | | [bemuse/src/music-collection/SongOfTheDay.ts](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL1NvbmdPZlRoZURheS50cw==) | `28.57% <ø> (ø)` | | | ... and [130 more](https://codecov.io/gh/bemusic/bemuse/pull/772/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.