bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.15k stars 149 forks source link

Fix problem where sign-in is broken #776

Closed dtinth closed 2 years ago

dtinth commented 2 years ago
image

A regression is introduced in #772, this PR fixes it.

Changelog

Fixed a regression where the sign in and sign up function doesn’t work.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 2 years ago

Codecov Report

Base: 81.05% // Head: 81.05% // No change to project coverage :thumbsup:

Coverage data is based on head (8aece5f) compared to base (945f536). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #776 +/- ## ======================================= Coverage 81.05% 81.05% ======================================= Files 178 178 Lines 5290 5290 Branches 242 242 ======================================= Hits 4288 4288 Misses 931 931 Partials 71 71 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [...online/scoreboard-system/createScoreboardClient.js](https://codecov.io/gh/bemusic/bemuse/pull/776/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vY3JlYXRlU2NvcmVib2FyZENsaWVudC5qcw==) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.