MikuroXina commented 1 year ago

This pull request contains following changes:

Use latest RxJS over old Bacon.js entirely,
Rewrite all JSX files with TSX,
Avoid global states with React Hooks and React Context API,
Refactor reducers with Slices API in @reduxjs/toolkit,
Remove impure dependency,
Write type declaration files,
Add unreleased field of SongMetadata in bemuse-types package.

Sorry about enormous changes. If you want to subdivide changes further, please tell me.

codecov-commenter commented 1 year ago

Codecov Report

Base: 88.32% // Head: 86.79% // Decreases project coverage by -1.53% :warning:

Coverage data is based on head (9360554) compared to base (717facb). Patch coverage: 72.58% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #790 +/- ## ========================================== - Coverage 88.32% 86.79% -1.54% ========================================== Files 175 174 -1 Lines 5293 5315 +22 Branches 269 376 +107 ========================================== - Hits 4675 4613 -62 - Misses 583 647 +64 - Partials 35 55 +20 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/app/query-flags.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcXVlcnktZmxhZ3MudHM=) | `16.66% <ø> (ø)` | | | [bemuse/src/game/state/player-stats.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL3N0YXRlL3BsYXllci1zdGF0cy50cw==) | `92.95% <ø> (ø)` | | | [bemuse/src/music-collection/getPlayableCharts.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL2dldFBsYXlhYmxlQ2hhcnRzLnRz) | `75.00% <ø> (ø)` | | | [bemuse/src/music-collection/sortSongs.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL3NvcnRTb25ncy50cw==) | `71.42% <ø> (ø)` | | | [...ne/scoreboard-system/createFakeScoreboardClient.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vY3JlYXRlRmFrZVNjb3JlYm9hcmRDbGllbnQudHM=) | `80.00% <ø> (ø)` | | | [...ne/scoreboard-system/createNextScoreboardClient.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vY3JlYXRlTmV4dFNjb3JlYm9hcmRDbGllbnQudHM=) | `0.00% <ø> (ø)` | | | [...emuse/src/music-collection/preprocessCollection.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL3ByZXByb2Nlc3NDb2xsZWN0aW9uLnRz) | `7.14% <7.14%> (ø)` | | | [bemuse/src/devtools/ui/BenchmarkPanel.tsx](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9kZXZ0b29scy91aS9CZW5jaG1hcmtQYW5lbC50c3g=) | `11.76% <11.76%> (ø)` | | | [bemuse/src/utils/now.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy91dGlscy9ub3cudHM=) | `26.66% <20.00%> (ø)` | | | [bemuse/src/omni-input/midi.ts](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbW5pLWlucHV0L21pZGkudHM=) | `25.00% <25.00%> (ø)` | | | ... and [37 more](https://codecov.io/gh/bemusic/bemuse/pull/790/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.