bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Refactor some main components #795

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

Separated from #790. The fixes which needs some improvements of the state management are not included.

codecov-commenter commented 1 year ago

Codecov Report

Base: 88.28% // Head: 88.27% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (5a5fa8d) compared to base (28494e4). Patch coverage: 11.76% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #795 +/- ## ========================================== - Coverage 88.28% 88.27% -0.02% ========================================== Files 175 175 Lines 5293 5295 +2 Branches 271 271 ========================================== + Hits 4673 4674 +1 - Misses 585 586 +1 Partials 35 35 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/devtools/ui/BenchmarkPanel.tsx](https://codecov.io/gh/bemusic/bemuse/pull/795/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9kZXZ0b29scy91aS9CZW5jaG1hcmtQYW5lbC50c3g=) | `11.76% <11.76%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dtinth commented 1 year ago

@MikuroXina I’ve just sent you an invite to collaborate on Bemuse. https://github.com/bemusic/bemuse/invitations

MikuroXina commented 1 year ago

@dtinth I've accepted, thanks for invitation! However, may I continue to contribute with my fork repository?

dtinth commented 1 year ago

@MikuroXina Of course, you can contribute in any way you are comfortable with. 😃