bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Refactor state management #805

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

Separated from #790. This is a preparation to fix components which depend on the state system.

codecov-commenter commented 1 year ago

Codecov Report

Base: 88.27% // Head: 87.46% // Decreases project coverage by -0.80% :warning:

Coverage data is based on head (76a0191) compared to base (8ad76a5). Patch coverage: 73.25% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #805 +/- ## ========================================== - Coverage 88.27% 87.46% -0.81% ========================================== Files 175 178 +3 Lines 5295 5395 +100 Branches 271 302 +31 ========================================== + Hits 4674 4719 +45 - Misses 586 635 +49 - Partials 35 41 +6 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/app/redux/collectionLoader.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcmVkdXgvY29sbGVjdGlvbkxvYWRlci50cw==) | `61.53% <61.53%> (ø)` | | | [bemuse/src/app/entities/Options.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvZW50aXRpZXMvT3B0aW9ucy50cw==) | `63.69% <63.69%> (ø)` | | | [bemuse/src/app/redux/optionsStorageMiddleware.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcmVkdXgvb3B0aW9uc1N0b3JhZ2VNaWRkbGV3YXJlLnRz) | `64.28% <64.28%> (ø)` | | | [bemuse/src/app/entities/MusicSearchText.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvZW50aXRpZXMvTXVzaWNTZWFyY2hUZXh0LnRz) | `76.92% <76.92%> (ø)` | | | [bemuse/src/app/redux/ReduxState.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcmVkdXgvUmVkdXhTdGF0ZS50cw==) | `77.77% <77.77%> (ø)` | | | [bemuse/src/app/entities/MusicSelection.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvZW50aXRpZXMvTXVzaWNTZWxlY3Rpb24udHM=) | `80.00% <80.00%> (ø)` | | | [bemuse/src/app/redux/configureStore.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcmVkdXgvY29uZmlndXJlU3RvcmUudHM=) | `80.00% <80.00%> (ø)` | | | [bemuse/src/app/redux/collectionFetchMiddleware.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcmVkdXgvY29sbGVjdGlvbkZldGNoTWlkZGxld2FyZS50cw==) | `81.81% <81.81%> (ø)` | | | [bemuse/src/app/entities/LoadState.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvZW50aXRpZXMvTG9hZFN0YXRlLnRz) | `88.23% <88.23%> (ø)` | | | [bemuse/src/app/entities/Collections.ts](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvZW50aXRpZXMvQ29sbGVjdGlvbnMudHM=) | `100.00% <100.00%> (ø)` | | | ... and [5 more](https://codecov.io/gh/bemusic/bemuse/pull/805/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication