bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Refactor online and Replace Bacon.js with RxJS #807

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

Separated from #790. react-rx is added for use useObservable, the hook API for Observable in RxJS.

codecov-commenter commented 1 year ago

Codecov Report

Base: 87.46% // Head: 86.76% // Decreases project coverage by -0.70% :warning:

Coverage data is based on head (a46cc0f) compared to base (f0181d3). Patch coverage: 75.16% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #807 +/- ## ========================================== - Coverage 87.46% 86.76% -0.71% ========================================== Files 178 175 -3 Lines 5395 5366 -29 Branches 302 325 +23 ========================================== - Hits 4719 4656 -63 - Misses 635 663 +28 - Partials 41 47 +6 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/app/entities/Options.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvZW50aXRpZXMvT3B0aW9ucy50cw==) | `63.63% <ø> (-0.07%)` | :arrow_down: | | [...ne/scoreboard-system/createFakeScoreboardClient.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vY3JlYXRlRmFrZVNjb3JlYm9hcmRDbGllbnQudHM=) | `80.00% <ø> (ø)` | | | [...ne/scoreboard-system/createNextScoreboardClient.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vY3JlYXRlTmV4dFNjb3JlYm9hcmRDbGllbnQudHM=) | `0.00% <ø> (ø)` | | | [bemuse/src/online/operations.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvb3BlcmF0aW9ucy50cw==) | `55.55% <55.55%> (ø)` | | | [bemuse/src/online/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvaW5kZXgudHM=) | `68.75% <68.75%> (ø)` | | | [...muse/src/online/scoreboard-system/OnlineService.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vT25saW5lU2VydmljZS50cw==) | `64.61% <68.75%> (ø)` | | | [bemuse/src/online/data-store.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvZGF0YS1zdG9yZS50cw==) | `76.47% <76.47%> (ø)` | | | [bemuse/src/online/data-store.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvZGF0YS1zdG9yZS5zcGVjLmpz) | `100.00% <100.00%> (ø)` | | | [bemuse/src/online/index.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvaW5kZXguc3BlYy5qcw==) | `99.42% <100.00%> (-0.02%)` | :arrow_down: | | [bemuse/src/online/level.ts](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvbGV2ZWwudHM=) | `100.00% <100.00%> (ø)` | | | ... and [6 more](https://codecov.io/gh/bemusic/bemuse/pull/807/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication