bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Refactor options components #810

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

Separated from #790.

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.76% // Head: 83.84% // Decreases project coverage by -2.92% :warning:

Coverage data is based on head (67cefb7) compared to base (0c7fbd8). Patch coverage: 18.25% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #810 +/- ## ========================================== - Coverage 86.76% 83.84% -2.93% ========================================== Files 175 175 Lines 5366 5378 +12 Branches 325 362 +37 ========================================== - Hits 4656 4509 -147 - Misses 663 821 +158 - Partials 47 48 +1 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/omni-input/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbW5pLWlucHV0L2luZGV4LnRz) | `17.27% <17.27%> (ø)` | | | [bemuse/src/omni-input/midi.ts](https://codecov.io/gh/bemusic/bemuse/pull/810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbW5pLWlucHV0L21pZGkudHM=) | `25.00% <25.00%> (ø)` | | | [bemuse/src/omni-input/index.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbW5pLWlucHV0L2luZGV4LnNwZWMuanM=) | `32.40% <0.00%> (-67.60%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication