bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Fix bugs in scoreboard #822

Closed dtinth closed 1 year ago

dtinth commented 1 year ago

Fixes #821

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.86% // Head: 86.49% // Decreases project coverage by -0.37% :warning:

Coverage data is based on head (7c5b053) compared to base (6ceeb04). Patch coverage: 35.89% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #822 +/- ## ========================================== - Coverage 86.86% 86.49% -0.38% ========================================== Files 175 178 +3 Lines 5315 5353 +38 Branches 358 363 +5 ========================================== + Hits 4617 4630 +13 - Misses 648 673 +25 Partials 50 50 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [...muse/src/online/scoreboard-system/OnlineService.ts](https://codecov.io/gh/bemusic/bemuse/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvc2NvcmVib2FyZC1zeXN0ZW0vT25saW5lU2VydmljZS50cw==) | `64.61% <ø> (ø)` | | | [bemuse/src/online/BatchedFetcher.ts](https://codecov.io/gh/bemusic/bemuse/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvQmF0Y2hlZEZldGNoZXIudHM=) | `15.78% <15.78%> (ø)` | | | [bemuse/src/online/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvaW5kZXgudHM=) | `63.44% <35.71%> (-5.31%)` | :arrow_down: | | [bemuse/src/online/queryKeys.ts](https://codecov.io/gh/bemusic/bemuse/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvcXVlcnlLZXlzLnRz) | `100.00% <100.00%> (ø)` | | | [bemuse/src/react-query/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9yZWFjdC1xdWVyeS9pbmRleC50cw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication