bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.14k stars 144 forks source link

Add typing of codes used by components #826

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

The last separation from #790.

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.51% // Head: 86.39% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (076766f) compared to base (479898b). Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #826 +/- ## ========================================== - Coverage 86.51% 86.39% -0.13% ========================================== Files 178 178 Lines 5362 5366 +4 Branches 363 382 +19 ========================================== - Hits 4639 4636 -3 - Misses 673 676 +3 - Partials 50 54 +4 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/app/query-flags.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvcXVlcnktZmxhZ3MudHM=) | `16.66% <ø> (ø)` | | | [bemuse/src/game/state/player-stats.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL3N0YXRlL3BsYXllci1zdGF0cy50cw==) | `92.95% <ø> (ø)` | | | [bemuse/src/music-collection/SongOfTheDay.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL1NvbmdPZlRoZURheS50cw==) | `31.25% <0.00%> (ø)` | | | [bemuse/src/music-collection/getPlayableCharts.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL2dldFBsYXlhYmxlQ2hhcnRzLnRz) | `75.00% <ø> (ø)` | | | [bemuse/src/music-collection/sortSongs.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL3NvcnRTb25ncy50cw==) | `71.42% <ø> (ø)` | | | [bemuse/src/online/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9vbmxpbmUvaW5kZXgudHM=) | `63.44% <0.00%> (ø)` | | | [...emuse/src/music-collection/preprocessCollection.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL3ByZXByb2Nlc3NDb2xsZWN0aW9uLnRz) | `8.33% <8.33%> (ø)` | | | [bemuse/src/music-collection/index.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL2luZGV4LnRz) | `35.71% <35.71%> (ø)` | | | [...e/src/music-collection/groupSongsIntoCategories.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL2dyb3VwU29uZ3NJbnRvQ2F0ZWdvcmllcy50cw==) | `75.00% <66.66%> (ø)` | | | [bemuse/src/app/interactors/findMatchingSong.ts](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9hcHAvaW50ZXJhY3RvcnMvZmluZE1hdGNoaW5nU29uZy50cw==) | `100.00% <100.00%> (ø)` | | | ... and [4 more](https://codecov.io/gh/bemusic/bemuse/pull/826?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication