search

bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.14k stars 144 forks source link

Refactor GameDisplay #827

Open MikuroXina opened 1 year ago

MikuroXina commented 1 year ago

For types, @types/jquery is added and screenfull is bumped.

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.39% // Head: 86.21% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (9e8dcce) compared to base (68e0d52). Patch coverage: 71.54% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #827 +/- ## ========================================== - Coverage 86.39% 86.21% -0.19% ========================================== Files 178 178 Lines 5366 5374 +8 Branches 382 426 +44 ========================================== - Hits 4636 4633 -3 - Misses 676 682 +6 - Partials 54 59 +5 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/game/display/touch3d.ts](https://codecov.io/gh/bemusic/bemuse/pull/827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2Rpc3BsYXkvdG91Y2gzZC50cw==) | `6.66% <0.00%> (ø)` | | | [bemuse/src/game/state/player-state.ts](https://codecov.io/gh/bemusic/bemuse/pull/827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL3N0YXRlL3BsYXllci1zdGF0ZS50cw==) | `86.07% <ø> (ø)` | | | [bemuse/src/game/display/player-display.ts](https://codecov.io/gh/bemusic/bemuse/pull/827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2Rpc3BsYXkvcGxheWVyLWRpc3BsYXkudHM=) | `71.30% <71.30%> (ø)` | | | [bemuse/src/game/display/Gauge.ts](https://codecov.io/gh/bemusic/bemuse/pull/827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2Rpc3BsYXkvR2F1Z2UudHM=) | `100.00% <100.00%> (ø)` | | | [bemuse/src/game/display/note-area.ts](https://codecov.io/gh/bemusic/bemuse/pull/827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2Rpc3BsYXkvbm90ZS1hcmVhLnRz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

MikuroXina commented 1 year ago

@dtinth Excuse me, could you review my PR? I forgot this.

dtinth commented 1 year ago

@MikuroXina Hello, I really apologize. I am currently very occupied with other stuff right now and probably do not have time to develop this project for a few months. 🙏

From a quick glance the code looks good to me, although I can’t play-test the game right now.

For the time being, please feel free to publish a forked version, and feel free to ask me if you need any help.