search

ben-aaron188 / netanos

NETANOS: Named entity-based Text Anonymization for Open Science'
https://www.npmjs.com/package/netanos
MIT License
10 stars 5 forks source link

Bugfix capital letter replacement #9

Closed maximilianmozes closed 6 years ago

maximilianmozes commented 6 years ago

PR related to the recent bug w.r.t. the context-preserving replacement. I identified and fixed the bug causing the strange results. @ben-aaron188 please have a look and test the updated code. We should proceed in the following order:

  1. Test NETANOS offline (use this code base).
  2. Deploy updated code to the server.
  3. Test NETANOS when deployed on the server.

Thanks!

ben-aaron188 commented 6 years ago

@maximilianmozes Sounds good to me. I tested the odd results we had and they seem fine now. So I'm happy to go ahead as you suggest.

maximilianmozes commented 6 years ago

Thanks @ben-aaron188. I deployed the code and kindly ask you to test it. :)

ben-aaron188 commented 6 years ago

@maximilianmozes Tested it: it does not anonymize (did it in FF and Chrome, both with file menu upload and d&d). I suspect it's either the server or dependency issues (e.g. drag_and_drop.css seems not to be linked). Can you check?

maximilianmozes commented 6 years ago

@ben-aaron188 Sorry, the server wasn't running. Should work now.

ben-aaron188 commented 6 years ago

@maximilianmozes Works. I'd say we're good to announce it. Will do so.