search

ben-cassese / squishyplanet

Transits of non-spherical exoplanets
https://squishyplanet.readthedocs.io/en/latest/
MIT License
4 stars 2 forks source link

Illustrate with non-limb-darkened star #1

Closed vegajustin26 closed 5 months ago

vegajustin26 commented 5 months ago

Tried to use OblateSystem.illustrate with a planet with no limb darkening and ran into an error of matplotlib.pyplot not knowing how to fill the contours: ValueError: Contour levels must be increasing.

Didn't realize that I should have also used 'star_fill=False' for it not to throw errors, but maybe 'star_fill = False' should be explicit in the backend of 'OblateSystem.illustrate' function if the limb darkening coefficients are zero? And/or illustrate could show a uniformly-brightened star instead?

ben-cassese commented 5 months ago

Thanks for the catch! Added a check for this in #2, it will now display a uniform disk when all of the limb darkening coefficients are set to zero.