search

ben-eb / gulp-csso

Minify CSS with CSSO.
MIT License
243 stars 26 forks source link

Gulp-sourcemaps support #4

Closed zslabs closed 8 years ago

zslabs commented 9 years ago

Any chance of adding in gulp-sourcemaps support? Would love to bundle this in. Thanks!

ben-eb commented 9 years ago

I'm not familiar with this, to be honest. Does it require that sourcemaps be available in the underlying library? If so there is an open issue for it, over here.

Or is it the case where you can generate the sourcemap directly in the vinyl stream? I'm a little bit out of the loop with this library! :smiley: If so, :+1: - if you know of an implementation and can send a PR, that'd be really good.

zslabs commented 9 years ago

Ah k, may be related to the other one. It looks "in theory" that it's a rather small snippet to add; as outlined in their Plugin developers only: How to add source map support to plugins section, but I'll defer to you on that ;)

ben-eb commented 9 years ago

:+1: on sourcemaps but I'm not familiar enough with the source-map library (which is for JS, can it do CSS too?) to add this feature upstream. You will notice on the wiki page for gulp-sourcemaps that plugins that expose this functionality are delegating to their underlying libraries, as I would have to do here. So, it's not a case of simply adding the feature to this module, that ability needs to be added into CSSO itself.

If someone has the capability to add this feature upstream then that'd be awesome.

/cc @MetaDriver

yocontra commented 9 years ago

+1 - I'll post on the csso issue and bug them

MetaDriver commented 9 years ago

  18.12.2014, 07:43, "Eric Schoffstall" notifications@github.com:+1 - I'll post on the csso issue and bug them—Reply to this email directly or view it on ОK.  It's well.  Thank you.My english is very bad for similar description.

ben-eb commented 9 years ago

Closing as csso has no active maintainers.

ben-eb commented 8 years ago

PR welcome.

https://github.com/css/csso/releases/tag/v1.6.0