ben-eb / gulp-svgmin

Minify SVG files with gulp.
MIT License
341 stars 35 forks source link

Update svgo@3 #129

Closed pioug closed 6 months ago

pioug commented 1 year ago

The breaking changes for svgo are described in https://github.com/svg/svgo/releases/tag/v3.0.0. I updated some tests accordingly.

There many additions in the package-lock.json apparently it wasn't synced previously.

npm ERR! code EUSAGE
npm ERR! 
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
....

@rejas @ben-eb Would you accept my help to maintain this project? I can do the basic chores and regularly update the project. Many of my work projects depend on gulp-svgmin, so I am happy to keep it healthy.

rejas commented 1 year ago

Hi @pioug I wouldnt mind passing my torch over to you since I dont really use gulp / gulp plugins anymore. But maybe moving this plugin to https://github.com/gulp-community might be an idea too?

pioug commented 1 year ago

Thanks for your reply @rejas !

The gulp-community doesn't seem very active 💦 The idea is good, but as is often the case with OSS projects, it's difficult to predict how long someone will be able to commit to the project.

I'd be happy to take on the maintenance of gulp-svgmin 🙌

If it's not too much to ask, I would need push permissions for the repository and publish permissions for npm (https://www.npmjs.com/~pioug).

If you make me an admin, I could also invite other contributors in the future too 🤔, but the decision is ultimately up to you!

rejas commented 1 year ago

the community might no tbe very active, but @phated seems to be quick to respond

but in the end its up to @ben-eb to decide how to move forward from this, since I dont have enough maintainership myself to do that.