search

ben-gibson / GitLink

A Jetbrains plugin that opens a local file under Git version control in its remote host using the default browser.
https://plugins.jetbrains.com/plugin/8183-gitlink
MIT License
727 stars 59 forks source link

Links to GitHub do not contain commit ID #291

Closed mrh1997 closed 1 year ago

mrh1997 commented 1 year ago

In contrary to GitLab links to GitHub do not contain the commit ID. This means when opening the links at a later time they can refer a different line (since somebody added a commit that inserted a line before the refererred line).

Sample for a GitHub Links: https://github.com/mrh1997/xyz/blob/main/src/components/Xyz.vue#L65-L65

Sample for a GitLab link (also created with GitLink), but including a commit ID: http://gitlab.com/mrh1997/xyz/-/blob/f0d324062d9a1f22a7aaea381d4fb222408e85db/bal27/formats/bf3file.py#L17-17

ben-gibson commented 1 year ago

Is this still a problem? The only reason I can think of it using the branch instead of the commit in the case of GitHub is if it can't find the commit on the GitHub remote.

mrh1997 commented 1 year ago

Looks like the problem is solved

dawei-nava commented 6 months ago

~This looks like a problem now, regression?~ Looks like i have to disable some fetching which takes too long.