search

ben-gibson / GitLink

A Jetbrains plugin that opens a local file under Git version control in its remote host using the default browser.
https://plugins.jetbrains.com/plugin/8183-gitlink
MIT License
671 stars 58 forks source link

Remove any scheme #295

Closed blaenk closed 1 year ago

blaenk commented 1 year ago

Thank you for working on this extension!

Instead of only removing ssh:// or git://, remove any scheme.

In my setup I use a fake scheme that is then intercepted by a custom git remote transport helper for a self-hosted GitLab instance.

Without this change, the custom scheme e.g. xy:// shows up in the resulting URL as xy/. See the issue below that this fixes.

The URL deduction is otherwise perfect.

Fixes https://github.com/ben-gibson/GitLink/issues/294

ben-gibson commented 1 year ago

Looks good, I’ll look at merging / releasing this over the weekend