Azure custom domain is not working

ben-gibson / GitLink

A Jetbrains plugin that opens a local file under Git version control in its remote host using the default browser.

https://plugins.jetbrains.com/plugin/8183-gitlink

MIT License

712 stars 59 forks source link

Azure custom domain is not working #329

Closed mutoe closed 1 week ago

mutoe commented 3 weeks ago

When I add a private deployed Azure Git Server in the Domain Registry, it can't detect that I'm using the azure as provider. Even if my remote url domain is azure.mydomain.com

I noticed that Azure is a hardcode domin, is this a bug or a requirement? https://github.com/ben-gibson/GitLink/blob/ce69784b86c495ff0bd7c6e8d021a16cd3b9e955/src/main/kotlin/uk/co/ben_gibson/git/link/url/factory/AzureUrlFactory.kt#L11

ben-gibson commented 2 weeks ago

That's strange. I'm not sure why it can't auto-detect Azure given you've registered your custom domain. I'll take a look one evening this week.

ben-gibson commented 2 weeks ago

Could you share the output of git remote -v in your repo? You can anonymise the domain, I just want to see how the rest of it is structured.

ben-gibson commented 1 week ago

I couldn't reproduce this exactly, but I've made some improvement around Azure URL generation in 4.5.0 that might help.