sys-cacher : uninstallation doesn't work

tlaurion commented 6 months ago

Commitment

I confirm that I have read the following resources:

Software version

Brief summary

Still having issues deploying sys-cacher correctly (tem[lates still hit tinyproxy which fails translating http->https). Consequently, uninstalling was attempted and fails.

Steps to reproduce

[user@dom0 ~/QubesIncoming/heads-tests-deb12-nix/qusal(main)]
$ qubesctl top.enable sys-cacher.deinit
local:
    ----------
    sys-cacher.deinit.top:
        ----------
        status:
            enabled
[user@dom0 ~/QubesIncoming/heads-tests-deb12-nix/qusal(main)]
$ qubesctl --templates state.apply
[WARNING ] top_file_merging_strategy is set to 'merge' and multiple top files were found. Merging order is not deterministic, it may be desirable to either set top_file_merging_strategy to 'same' or use the 'env_order' configuration parameter to specify the merging order.
[CRITICAL] Rendering SLS 'base:sys-cacher.untag' failed: could not find expected ':'
local:
    Data failed to compile:
----------
    Rendering SLS 'base:sys-cacher.untag' failed: could not find expected ':'
DOM0 configuration failed, not continuing
[user@dom0 ~/QubesIncoming/heads-tests-deb12-nix/qusal(main)]
(1)$ qubesctl state.apply sys-cacher.remove-policy
local:
----------
          ID: sys-cacher-absent-rpc-policy
    Function: file.absent
        Name: /etc/qubes/policy.d/75-sys-cacher.policy
      Result: True
     Comment: Removed file /etc/qubes/policy.d/75-sys-cacher.policy
     Started: 15:03:52.522713
    Duration: 26.476 ms
     Changes:   
              ----------
              removed:
                  /etc/qubes/policy.d/75-sys-cacher.policy

Summary for local
------------
Succeeded: 1 (changed=1)
Failed:    0
------------
Total states run:     1
Total run time:  26.476 ms
[user@dom0 ~/QubesIncoming/heads-tests-deb12-nix/qusal(main)]
$ qubesctl state.apply sys-cacher.untag
[CRITICAL] Rendering SLS 'base:sys-cacher.untag' failed: could not find expected ':'
local:
    Data failed to compile:
----------
    Rendering SLS 'base:sys-cacher.untag' failed: could not find expected ':'
DOM0 configuration failed, not continuing

Expected behavior

applying deinstallation steps from README should work as described

Actual behavior

seems like syntax errors are present and fails from untag.

ben-grande commented 6 months ago

Still having issues deploying sys-cacher correctly (tem[lates still hit tinyproxy which fails translating http->https).

I don't face this issue. Did you make sure that the templates are tagged? Also maybe due to changes I did on the tag name.

Check the tag of the templates.

Monitor qrexec policy:

sudo journalctl -fu qubes-qrexec-policy-daemon | cut -d " " -f6-

Try to update the template.

Thanks for reporting the commit version, it helps a lot to know that.

I search for the issue in untag.sls.

ben-grande commented 6 months ago

The untag issue is fixed now.

If you have time, I'd greatly appreciate more information on the issues you encountered with using the cacher so I can fix it. I don't encounter such issues and I use it a lot on Debian and some Fedora templates.

ben-grande / qusal