search

ben-grande / qusal

Salt Formulas for Qubes OS.
19 stars 7 forks source link

fedora-minimal misses python3-urllib3 #38

Closed tlaurion closed 6 months ago

tlaurion commented 6 months ago

Commitment

I confirm that I have read the following resources:

Software version

81bf77c

Brief summary

Followed BOOTSTRAP.md to install dom0 requirements in order defined there. fedora-minimal fails with python3-urrllib3 missing

Steps to reproduce

deploy dom0, debian-minimal, fedora-minimal, sys-cacher and then mgmt fedora-minimal fails while mgmt succeeds (later install missing dep of the former)

Expected behavior

BOOTSTRAP defined steps should work as described. Just deployed clean on freshly received nv41 for testing clean.

Actual behavior

Fails at fedora-minimal. mgmt deploys the missing dep?

ben-grande commented 6 months ago

I though I had fixed it in https://github.com/ben-grande/qusal/commit/b240ad6c5e59c276432397a5fe22b4fbd75dd2fd. Relevant issue:

But now I see the problem, that change should have partially been made to fedora-minimal and not to mgmt entirely. Thanks for reporting.

ben-grande commented 6 months ago

It affects everyone that has installed fedora-minimal already, but after the following Marek's commit reachs the stable template: https://github.com/QubesOS/qubes-builder-rpm/commit/fa42621395a89eceacdcc701c3a672df33791b63, it will not apply for future template installs. But reinstalling a template is not common unfortunately so I will have to keep that workaround for some time.

tlaurion commented 6 months ago

Changing bootstrap dependencies order to deploy dom0 and then mgmt could be a woraround AFAIK.

Also not trusting creation worked and checking if parent fedora-minimal contains the requirements?

On Sat, Mar 23, 2024, 8:36 AM ben-grande @.***> wrote:

It affects everyone that has installed fedora-minimal already, but after the following Marek's commit reachs the stable template: @.*** https://github.com/QubesOS/qubes-builder-rpm/commit/fa42621395a89eceacdcc701c3a672df33791b63, it will not apply for future template installs. But reinstalling a template is not common unfortunately so I will have to keep that workaround for some time.

— Reply to this email directly, view it on GitHub https://github.com/ben-grande/qusal/issues/38#issuecomment-2016481308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGKBMWHKRZWBVBZZD3VD53YZVZLVAVCNFSM6AAAAABFEB7MZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGQ4DCMZQHA . You are receiving this because you authored the thread.Message ID: @.***>

ben-grande commented 6 months ago

Changing bootstrap dependencies order to deploy dom0 and then mgmt could be a woraround AFAIK.

I didn't make it clear in the bootstrap guide, the order of the formulas does not matter for them to work, but applying in the specified order gives the best results:

You can do it in any order, I am just recommending this order for the best experience. If you don't install and update templates early, and cache packages, and minimal mgmt dvm, you will have to spend more time updating and longer runtime overall.

Also not trusting creation worked and checking if parent fedora-minimal contains the requirements?

Possible but requires:

  1. Check if template tpl-qubes-builder exists (depends on fedora-minimal): 1.1. If it doesn't exist, starting fedora-minimal and check if it has dependency python3-urllib3. If it doesn't, install and shut it down, if it has, shutdown and clone template. 1.2 If template exists, guarantee it has python3-urrlib3

I think I will settle to install python3-urllib3 for every template that depends on fedora-minimal (`1.2) so it is always present and I don't need to check the base template every time.

ben-grande commented 6 months ago

One thing also is that to target fedora-39-minimal, you need to have a fedora-39 (full) present and as the management_dispvm, that is unfortunately, necessary. As mgmt depends on fedora-minimal, it also depends on fedora, so this order is necessary.