Closed ben-grande closed 2 weeks ago
Commit https://github.com/ben-grande/qusal/commit/084d08f7c5a3ffd5b1e6e1867ec3a27fd4212d55 will break installation via top. Please install via the state mode.
On Mon, Mar 25, 2024, 12:18 PM ben-grande @.***> wrote:
Software version
Any. Brief summary
Easy deinit of sys-cacher can't be done on non-templates as Qubes Salt pillars have not implemented ability to detect tags. This makes it harder for non-templates https://github.com/ben-grande/qusal/blob/fb7db5dc4527306f9e21f2c2ca0c9e1ae21eaf47/salt/sys-cacher/deinit.top#L12 to be uninstalled in the top format. Steps to reproduce
Try to deinit non-templates. Expected behavior
Uninstall from all qubes. Actual behavior
Uninstall only in templates
As of now, you can uninstall from any qube by deleting the tag, removing the updates-proxy-setup service and running the uninstall-client state. Proposed solution
Gonzalo Bulnes did qvm-tags-in-pillar https://github.com/gonzalo-bulnes/qubes-mgmt-salt-user/tree/main/packages/qvm-tags-in-pillar/src/qvm-tags-in-pillar-formula, it makes sense for this formula to be upstreamed to Qubes OS rather than pulled to Qusal, but it depends on how much time it will take to be included in Qubes stable repos.
It can make sense for tags to be added to qubesctl, then the state solution will be easier to write than to discover which qubes have a tag and then call qubesctl on the command line, which can lead to typos.
— Reply to this email directly, view it on GitHub https://github.com/ben-grande/qusal/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCE2O4P23SNXUGGKIUXDA4DY2AB2DAVCNFSM6AAAAABFG2BE7KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDKNJQGUZDSMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
will break installation via top
Never mind, instructions are correct.
Opened a PR to QubesOS. Let's wait a bit and see if it is accepted.
Software version
Any.
Brief summary
Easy deinit of sys-cacher can't be done on non-templates as Qubes Salt pillars have not implemented ability to detect tags. This makes it harder for non-templates to be uninstalled in the top format.
Steps to reproduce
Try to deinit non-templates.
Expected behavior
Uninstall from all qubes.
Actual behavior
Uninstall only in templates
As of now, you can uninstall from any qube by deleting the tag, removing the updates-proxy-setup service and running the uninstall-client state.
Proposed solution
Gonzalo Bulnes did qvm-tags-in-pillar, it makes sense for this formula to be upstreamed to Qubes OS rather than pulled to Qusal, but it depends on how much time it will take to be included in Qubes stable repos.
It can make sense for
tags
to be added toqubesctl
, then the state solution will be easier to write than to discover which qubes have a tag and then call qubesctl on the command line, which can lead to typos.Comment of mine on Gonzalo project asking to upstream it.