search

ben-grande / qusal

Salt Formulas for Qubes OS.
14 stars 6 forks source link

sys-print : explicit tagging of qubes instructions missing in doc #63

Closed tlaurion closed 2 weeks ago

tlaurion commented 2 weeks ago

Commitment

I confirm that I have read the following resources:

Current problem (if any)

Instructions somehow say how to come to the following, modifying policy (which, how: qubes policy editor)

# SPDX-FileCopyrightText: 2024 Benjamin Grande M. S. <ben.grande.b@gmail.com>
#
# SPDX-License-Identifier: AGPL-3.0-or-later

## Do not modify this file, create a new policy with with a lower number in the
## file name instead. For example `30-user.policy`.
qusal.Print * @tag:print-client @default allow target=sys-print
qusal.Print * @anyvm @tag:print-server ask
qusal.Print * @anyvm @default ask default_target=sys-print
qusal.Print * @anyvm @anyvm deny
## vim:ft=qrexecpolicy

https://github.com/ben-grande/qusal/commit/f30bd20f54663193a15f28b168ff71e83ada9856 Instructions says that print-client tag will allow automatically clients, but doesn't say how:

$ qvm-tags QUBE add print-client

Proposed solution

Add qvm-tags QUBE add print-client to be consistent with other salt/README.md docs and not leave the end user think too much

The value to a user, and who that user might be

Have something working out of the box, not wonder around and understand everything prior of being able to print his first document.