ben-grande
commented
3 days ago Almost a good commit message. See the error in the CI log.
See how I handled another PR where the commit was not linted https://github.com/ben-grande/qusal/pull/75#issuecomment-2186756887
See how to create a dev environment for contributing to Qusal:
The dev formula is also listed in the Requirements section of the contribution guidelines.
You also did use the GitHub web to create the commit, it is signed by GitHub web-flow signature. GitHub web-flow does not allow you to amend the commit as far as I know and searched just now.
If I could, I'd block GitHub web-flow automatically so contributors don't take the shortcut that costs more on the long run.
The reason why Github Action did not run when you opened the PR is that I set a policy for first time contributors to not run workflows automatically, this is to avoid accounts spamming my actions and exceeding the usage limit, which is 2.000 minutes on the free plan.
If I could add marmarek/signature-checker as a Github Action, I would, but even them this check would not fail as it does not prohibit the key Github web-flow yet (can customize the qubesinfra.CheckPRSignature though):
$ env GPGV=gpgv check-git-signature --clone https://github.com/ben-grande/qusal --pull-request 85 --verbose --debug --print-keyid
Cloning https://github.com/ben-grande/qusal into /tmp/tmp575u8qyn/repo
Repository URL is https://github.com/ben-grande/qusal
Fetching pull request data from https://api.github.com/repos/ben-grande/qusal/pulls/85
Verifying commit bc69b3b6cb55cb2ac1f2d8f363823617c9c984da
GPG status line: [GNUPG:] ERROR add_keyblock_resource 33587281
GPG status line: [GNUPG:] NEWSIG
GPG status line: [GNUPG:] ERROR keydb_search 33554445
GPG status line: [GNUPG:] ERRSIG B5690EEEBB952194 1 8 00 1719795346 9 -
GPG status line: [GNUPG:] NO_PUBKEY B5690EEEBB952194
Missing key B5690EEEBB952194 (download: True)
GPG status line: [GNUPG:] NEWSIG
GPG status line: [GNUPG:] KEY_CONSIDERED 968479A1AFF927E37D1A566BB5690EEEBB952194 0
GPG status line: [GNUPG:] SIG_ID Ax/3JUbYn1MOSI66OFRgM7A9Lt0 2024-07-01 1719795346
GPG status line: [GNUPG:] KEY_CONSIDERED 968479A1AFF927E37D1A566BB5690EEEBB952194 0
GPG status line: [GNUPG:] GOODSIG B5690EEEBB952194 GitHub <noreply@github.com>
Commit verification result: ('B5690EEEBB952194 downloaded from hkps://keyserver.ubuntu.com', True)
B5690EEEBB952194 downloaded from hkps://keyserver.ubuntu.com
$ echo $?
0Enforcing commit signature has two effects:
- Trust is attributed to the contributor instead of what is said in the Github interface.
- Guarantee user did setup git locally instead of using Github web.
I did a git patch manually and signed off and added my signature, this is an exception in the hopes of having an up-to-date documentation. Please setup your dev environment.
The mullvad-browser install command had an extraneous '-browser' suffix that was causing the command to fail. This commit removes the unnecessary suffix, correcting the install command so that it can execute properly.