search

ben-grande / qusal

Salt Formulas for Qubes OS.
14 stars 6 forks source link

fix typos in sys-ssh-agent README.md #87

Open wassp-ds opened 3 days ago

wassp-ds commented 3 days ago

Commitment

I confirm that I have read the following resources:

Software version

Brief summary

Change all instances of qusal-ssh-agent-forwarder to qubes-ssh-agent-forwarder

Steps to reproduce

Expected behavior

Setup works out of the box when following the README steps.

Actual behavior

Following the steps directly causes the client set up to fail.

.

ben-grande commented 3 days ago

Change all instances of qusal-ssh-agent-forwarder to qubes-ssh-agent-forwarder

Change from qubes- to qusal- was intentional to create a distinction of Qubes services vs Qusal services.

Following the steps directly causes the client set up to fail.

Can you be more verbose? I don't have a way to debug based on this.

ben-grande commented 3 days ago

Try running the sys-ssh-agent steps again though:

sudo qubesctl --skip-dom0 --targets=tpl-sys-ssh-agent sys-ssh-agent.install
sudo qubesctl --skip-dom0 --targets=tpl-dev dev.install
wassp-ds commented 3 days ago

What I am doing is playing dumb and blindly copying and pasting the commands from subsequent READMEs to see whether the instructions make sense. In this instance, following the instructions client-side:

% sudo systemctl --no-block restart qusal-ssh-agent-forwarder@personal.service
Failed to restart qusal-ssh-agent-forwarder@personal.service: Unit qusal-ssh-agent-forwarder@personal.service not found.

after the set up sys-ssh-agent is complete. Running the command with qubes-ssh-agent-forwarder, the mechanism works as intended. I guess the missing step in the doc is either what you suggested above and it would work out of the box, or there is an extra step missing of turning the service on, client side. Or something else :smile:

ben-grande commented 3 days ago

Did you restart the qubes after modifications are done to the templates? Restart dev.

On Mon, Jul 1, 2024, 6:55 PM wassp-ds @.***> wrote:

What I am doing is playing dumb and blindly copying and pasting the commands from subsequent READMEs to see whether the instructions make sense. In this instance, following the instructions client-side:

% sudo systemctl --no-block restart @. Failed to restart @.: Unit @.*** not found.

after the set up sys-ssh-agent is complete. Pointing it to qubes-ssh-agent-forwarder, the mechanism works as intended. I guess the missing step in the doc is either what you suggested above and it would work out of the box, or there is an extra step missing of turning the service on, client side. Or something else 😄

— Reply to this email directly, view it on GitHub https://github.com/ben-grande/qusal/issues/87#issuecomment-2200626360, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCE2O4ILO76WLWYOWDQI4WLZKGCZXAVCNFSM6AAAAABKFYPX52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYZDMMZWGA . You are receiving this because you commented.Message ID: @.***>