Url template broken in report for neo4j

TWiStErRob commented 5 years ago

Unexpected ${project.artifactId}/${project.version} in url:

The following dependencies have later milestone versions:
 - org.neo4j:neo4j-cypher [3.3.6 -> 3.5.8]
     http://components.neo4j.org/${project.artifactId}/${project.version}
 - org.neo4j:neo4j-kernel [3.3.6 -> 3.5.7]
     http://components.neo4j.org/${project.artifactId}/${project.version}
 - org.neo4j.test:neo4j-harness [3.3.6 -> 3.5.7]
     http://components.neo4j.org/${project.artifactId}/${project.version}

Repro: gradle dependencyUpdates on

plugins {
    id 'java'
    id 'com.github.ben-manes.versions' version '0.21.0'
}

ext.ver = [
        neo4j: '3.3.6',
]

repositories {
    jcenter()
}

dependencies {
    runtimeOnly("org.neo4j:neo4j-cypher:${ver.neo4j}")
    runtimeOnly("org.neo4j:neo4j-kernel:${ver.neo4j}") { transitive = true }
    testImplementation "org.neo4j.test:neo4j-harness:${ver.neo4j}"
}

Possible this is a publishing issue in neo4j, not sure where that url comes from.

gabrielittner commented 5 years ago

The issue is in Neo4J's published pom, the project url is taken directly from there https://repo1.maven.org/maven2/org/neo4j/neo4j/3.5.8/neo4j-3.5.8.pom

On Sun, 21 Jul 2019, 15:00 Róbert Papp, notifications@github.com wrote:

Unexpected ${project.artifactId}/${project.version} in url:

The following dependencies have later milestone versions:

org.neo4j:neo4j-cypher [3.3.6 -> 3.5.8] http://components.neo4j.org/${project.artifactId}/${project.version}

org.neo4j:neo4j-kernel [3.3.6 -> 3.5.7] http://components.neo4j.org/${project.artifactId}/${project.version}

org.neo4j.test:neo4j-harness [3.3.6 -> 3.5.7] http://components.neo4j.org/${project.artifactId}/${project.version}

Repro: gradle dependencyUpdates on

plugins { id 'java' id 'com.github.ben-manes.versions' version '0.21.0' }

ext.ver = [ neo4j: '3.3.6', ] repositories { jcenter() } dependencies { runtimeOnly("org.neo4j:neo4j-cypher:${ver.neo4j}") runtimeOnly("org.neo4j:neo4j-kernel:${ver.neo4j}") { transitive = true } testImplementation "org.neo4j.test:neo4j-harness:${ver.neo4j}" }

Possible this is a publishing issue in neo4j, not sure where that url comes from.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ben-manes/gradle-versions-plugin/issues/319?email_source=notifications&email_token=AAKLSGKUGKVWW2DQ2MOUISTQARMX7A5CNFSM4IFSGPUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HAPQTPA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKLSGL22SSOAH36AYEZK63QARMX7ANCNFSM4IFSGPUA .

TWiStErRob commented 5 years ago

Those substitutions seem to be correct, the values are defined right above it:

<project>
...
<artifactId>neo4j</artifactId>
<version>3.5.8</version>
...
<url>http://components.neo4j.org/${project.artifactId}/${project.version}</url>
...
</project>

It's a standard pom.xml feature: https://maven.apache.org/pom.html#Properties It feels like the problem is in this plugin, as it is reading a valid pom.xml file.

ben-manes / gradle-versions-plugin

Url template broken in report for neo4j #319