search

ben-manes / gradle-versions-plugin

Gradle plugin to discover dependency updates
Apache License 2.0
3.83k stars 200 forks source link

Address inspection hints #719

Closed sschuberth closed 1 year ago

sschuberth commented 1 year ago

Please have a look at the individual commit messages for the details.

ben-manes commented 1 year ago

lgtm, thanks! Seems there are some minor KtLint errors, so can merge once the checks pass.

sschuberth commented 1 year ago

lgtm, thanks! Seems there are some minor KtLint errors, so can merge once the checks pass.

Should be addressed now, incl. on more inspection fix.

BTW, very cool that this is Kotlin now 😀

sschuberth commented 1 year ago

Any idea why lines like this are gone from the actual output with my first commit in this PR? Is it really correct that these lines are expected to be there?

ben-manes commented 1 year ago

That is the dependency.reason. Maybe your refactoring to Coordinate no longer provides it?