Closed Vampire closed 1 year ago
Thanks! Can you fix the test failures? It might just be some minor updates, e.g.
DependencyUpdatesSpec > Single project with flatDir repository FAILED
Condition not satisfied:
unresolved.collect { it.selector }.collectEntries { dependency -> [['group': dependency.group, 'name': dependency.name]: dependency.version] } == [['group': 'null', 'name': 'guava-18.0']: NONE_VERSION]
| | | | |
| [:guava-18.0:none] [[group:, name:guava-18.0]:none] false none
[:guava-18.0:none]
at com.github.benmanes.gradle.versions.DependencyUpdatesSpec.Single project with flatDir repository_closure21(DependencyUpdatesSpec.groovy:359)
at groovy.lang.Closure.call(Closure.java:412)
at spock.lang.Specification.with(Specification.java:191)
at com.github.benmanes.gradle.versions.DependencyUpdatesSpec.Single project with flatDir repository(DependencyUpdatesSpec.groovy:358)
Hm, I'm not sure about the undeclared failure, whether my changes just surfaced that there is some other bug in Resolver.kt
or whether my changes are problematic.
With the current state the guice
dependency is also treated as hidden.
Can you maybe have a look?
Actually if I comment out the if (originalCoordinate == null && resolvedCoordinate.groupId != "none") {
and just keep the else
, the tests in DependencyUpdatesSpec
all pass.
Maybe it is not necessary and not appropriate actually as there is already Ignore undeclared (hidden) dependencies
at an earlier place in that file?
I pushed a version with that change, let's see whether something else breaks or you say this actually is necessary. :-)
Well, the tests passed with that change :-D
Fixes #725